Declaring classifier_dropout in model config but not using it

[PhilipMay]

The PEGASUS model is declaring classifier_dropout in the model config:

transformers/src/transformers/models/pegasus/configuration_pegasus.py

Line 128 in 546dc24

classifier_dropout=0.0,

But the model never uses it. This is a bug IMO.

In contrast mBART defines it:

transformers/src/transformers/models/mbart/configuration_mbart.py

Line 127 in 546dc24

classifier_dropout=0.0,

and uses it:

transformers/src/transformers/models/mbart/modeling_mbart.py

Line 1395 in 546dc24

config.classifier_dropout,

If wanted I can provide a fix (non breaking) as a PR.

[PhilipMay]

Tagging @NielsRogge

[PhilipMay]

also see this issue: #12781

[PhilipMay]

@NielsRogge what do you think?

[PhilipMay]

Well, since Pegasus does not have SequenceClassification or TokenClassification the classifier_dropout could be just removed from the config.

[PhilipMay]

fixed in PR - closing