Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lora+: include lr in optimizer kwargs #1973

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fix: lora+: include lr in optimizer kwargs #1973

merged 4 commits into from
Jul 30, 2024

Commits on Jul 30, 2024

  1. fix: lora+: include lr in optimizer kwargs

    @kallewoof
    kallewoof committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    1780b3a View commit details
    Browse the repository at this point in the history

  2. remove lr from args list as it is now in kwargs

    @kallewoof
    kallewoof committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    de4f83a View commit details
    Browse the repository at this point in the history

  3. put lr into kwargs instead

    @kallewoof
    kallewoof committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    a36a872 View commit details
    Browse the repository at this point in the history

  4. restore comment

    @kallewoof
    kallewoof committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0a07313 View commit details
    Browse the repository at this point in the history