put lr into kwargs instead

huggingface · Jul 30, 2024 · a36a872 · a36a872
1 parent de4f83a
commit a36a872
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/peft/optimizers/loraplus.py b/src/peft/optimizers/loraplus.py
@@ -30,7 +30,7 @@
 
 
 def create_loraplus_optimizer(
-    model: PeftModel, optimizer_cls: type[Optimizer], *, loraplus_lr_ratio: float, **kwargs
+    model: PeftModel, optimizer_cls: type[Optimizer], *, lr: float, loraplus_lr_ratio: float, **kwargs
 ) -> Optimizer:
     """
     Creates a LoraPlus optimizer.
@@ -81,7 +81,7 @@ def create_loraplus_optimizer(
         else:
             param_groups["groupA"][name] = param
 
-    lr = kwargs["lr"]
+    kwargs["lr"] = lr
     loraplus_weight_decay = kwargs.pop("loraplus_weight_decay", 0.0)
     loraplus_lr_embedding = kwargs.pop("loraplus_lr_embedding", 1e-6)