Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing = None in GitRefs for pull_requests. #1956

Closed
PhilipMay opened this issue Jan 4, 2024 · 1 comment · Fixed by #1960
Closed

Missing = None in GitRefs for pull_requests. #1956

PhilipMay opened this issue Jan 4, 2024 · 1 comment · Fixed by #1960

Comments

@PhilipMay
Copy link

PhilipMay commented Jan 4, 2024 •
edited
Loading

huggingface_hub/src/huggingface_hub/hf_api.py

Line 1097 in a331e82

pull_requests: Optional[List[GitRefInfo]]

pull_requests is marked as Optional but I think an = None is missing.

Also see the issue here: UKPLab/sentence-transformers#2396 (comment)
@PhilipMay PhilipMay mentioned this issue Jan 4, 2024
Merged
@Wauplin Wauplin mentioned this issue Jan 5, 2024
Merged
@Wauplin
Copy link
Contributor

Wauplin commented Jan 5, 2024

Thanks for reporting @PhilipMay! I opened #1960 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make GitRefs backward comp huggingface/huggingface_hub
2 participants
@PhilipMay @Wauplin