Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wheel events no longer working in chrome/opera/firefox in the presence of both a touch pad and a mouse #71

Open
mitchbassProbus opened this issue Sep 15, 2017 · 5 comments

Comments

@mitchbassProbus
Copy link

when i load zpd in chrome/opera/firefox wheel events are longer being handled by zpd...

superficial assessment is that the test in _setupHandlers is taking the 'mobile' path when it should take the 'desktop' path.

workaround is to change the 'if mobile then if desktop' structure into separate independent tests, e.g. if mobile and then independently if desktop... same change also applies to _tearDownHandlers.

@hueitan
Copy link
Owner

hueitan commented Sep 15, 2017

I just tried on chrome, wheeling (zooming) works.

workaround is to change the 'if mobile then if desktop' structure into separate independent tests, e.g. if mobile and then independently if desktop... same change also applies to _tearDownHandlers.

I think i understand what you mean and you are correct, since the desktop might support touch event

looks like we need a better detection whether it is desktop or mobile.

@mitchbassProbus
Copy link
Author

i have a workstation that has both a mouse and a touch screen monitor, hence having both is possible.

@mitchbassProbus
Copy link
Author

oops, wrong button...

@mitchbassProbus mitchbassProbus changed the title wheel events no longer working in chrome/opera/firefox wheel events no longer working in chrome/opera/firefox in the presence of both a touch pad and a mouse Sep 15, 2017
@hueitan
Copy link
Owner

hueitan commented Sep 15, 2017

nice, do you want to submit a pr that follows what you said here

change from if mobile then if desktop to if mobile, if desktop form?

@absvm
Copy link

absvm commented Sep 11, 2018

I had the same issue and fixed it according to the suggestions here. Wanted to commit/push and create a PR but had no rights....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants