Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be an option to disable showing success message. #6

Closed
chandermani opened this issue Feb 7, 2014 · 6 comments
Closed
Milestone

Comments

@chandermani
Copy link

Currently the directive either shows error or success.

There should be an option to allow not showing success message at all.

@hueitan hueitan added this to the Improvemen milestone Feb 8, 2014
@hueitan
Copy link
Owner

hueitan commented Feb 8, 2014

Ok, working for it!

@hueitan hueitan modified the milestones: Improvemen, 1.1.0 Feb 8, 2014
@hueitan
Copy link
Owner

hueitan commented Feb 8, 2014

In this Issue,

attribute noValidationMsg consider to depreciate

or consider noValidationMsg will call the provider to disable validation msg

and

replace with given these provider names
showValidationMsg showSuccessValidationMsg showErrorValidationMsg
setShowValidationMsg setShowSuccessValidationMsg setShowErrorValidationMsg

these names are too long !!

Way to go ~

@chandermani
Copy link
Author

I believe since the context fo this directive is validation, you can do away with validation keyword. So it become showMessage, showSuccessMessage etc.

@hueitan
Copy link
Owner

hueitan commented Feb 8, 2014

you are right, thanks again !

@hueitan
Copy link
Owner

hueitan commented Apr 11, 2014

Hey @chandermani

Sorry for the late reply.

Try $validationProvider.showSuccessMessage = false; in angular config status.

Seems this is a config section, so I don't implement this through directive attrs.

Issue me if you have other question.

Thanks again.

@hueitan hueitan closed this as completed Apr 11, 2014
@chandermani
Copy link
Author

Greate! and thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants