You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently there are a bunch of check performed during as_config().
Check the schema_id prefix url
Check the schema_id version is a valid released version (requires internet connection - annoying during new schema version development)
Check config level 1 property names against schema (requires internet connection and valid schema_id to download schema)
Check that the schema file name can be parsed correctly to extract the config type
Performing these checks when coercing a list in R seems sensible, but requiring an internet connection and re-performing checks that should have been performed vi validate_config() to just load a json config file seems excessive.
Proposal
At the very least I feel we should be able to bypass checks 2 & 3 with a skip_schema_checks argument in as_config() that is set to TRUE when using as_config() as part of read_config_file().
Check 3 should only deploy if check 2 is successful
Open to suggestions for cleaner more intuitive approaches.
Relatedly, if any errors are thrown in as_config(), the read_config() and read_config_file() still fail to return a config class object, however they now it do so silently by default. Is this the desired behaviour? If not, what is the desired behaviour?
The text was updated successfully, but these errors were encountered:
Backrgound
Currently there are a bunch of check performed during
as_config()
.Performing these checks when coercing a list in R seems sensible, but requiring an internet connection and re-performing checks that should have been performed vi
validate_config()
to just load a json config file seems excessive.Proposal
skip_schema_checks
argument inas_config()
that is set toTRUE
when usingas_config()
as part ofread_config_file()
.Open to suggestions for cleaner more intuitive approaches.
Relatedly, if any errors are thrown in
as_config()
, theread_config()
andread_config_file()
still fail to return aconfig
class object, however they now it do so silently by default. Is this the desired behaviour? If not, what is the desired behaviour?The text was updated successfully, but these errors were encountered: