add tests for require(hubot/es2015) #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gr2m
force-pushed
the
evolution/4/test-es2015-export
branch
2 times, most recently
from
ae272d5
to
c99cbff
Compare
gr2m
force-pushed
the
evolution/4/test-es2015-export
branch
from
c99cbff
to
e744f62
Compare
technicalpickles
approved these changes
Jun 28, 2017
| @@ -24,6 +24,6 @@ module.exports = { | |||
| CatchAllMessage: Message.CatchAllMessage, | |||
|
|
|||
| loadBot (adapterPath, adapterName, enableHttpd, botName, botAlias) { | |||
| return new Robot(adapterPath, adapterName, enableHttpd, botName, botAlias) | |||
| return new module.exports.Robot(adapterPath, adapterName, enableHttpd, botName, botAlias) | |||
There was a problem hiding this comment.
Was this not working previously?
There was a problem hiding this comment.
it worked, but this way we can stub Robot in tests
https://github.com/hubotio/hubot/pull/1359/files#diff-0740e6d4a0c565b774aca19f820a7550R193
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of hubotio/evolution#4