-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add latest release #343
add latest release #343
Conversation
It seems the indentation is off though. |
@kamontat I'm also not a member. @Shredder121 taking the opportunity, do you know how to run tests locally if I have no access to repositories and organisations that are referenced from the unit tests? |
You can read test code, it uses file with local configuration. Create additional account and run using it. |
@@ -298,6 +298,10 @@ public GHRef createRef(String name, String sha) throws IOException { | |||
public List<GHRelease> getReleases() throws IOException { | |||
return listReleases().asList(); | |||
} | |||
|
|||
public GHRelease latestRelease() throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be getLatestRelease
,
fix indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be getLatestRelease,
fix indentation
@KostyaSha I know that, but it still fails. Is there any list of what scopes an access token needs to pass the tests? |
@Shredder121 I already testing on it in my own repository, so I sure it's work but I don't push my test up because I test by using my own repository. |
I already add the latest release, so please add to master and update version so that I can use in my project
Fix #341
PS I don't know how to push my fixed module to the maven server so, please. @emlagowski
Thank you