Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub.createToken support passing an OTP, thus supporting 2fa #602

Closed
madhephaestus opened this issue Nov 9, 2019 · 1 comment · Fixed by #603
Closed

GitHub.createToken support passing an OTP, thus supporting 2fa #602

madhephaestus opened this issue Nov 9, 2019 · 1 comment · Fixed by #603

Comments

@madhephaestus
Copy link
Contributor

#292 was not resolved despite being marked resolved. With 2fa enabled, the API requires users to go out of pipeline (into a web browser) to generate tokens. This is problematic from an instructions standpoint.

This is also not necessary.

If create token took an OTP, then the users program could hold and prompt the user to the OTP that comes from SMS. The OTP can be added to the token request via this field:

https://developer.github.com/v3/auth/#working-with-two-factor-authentication

If the API had a field to accept the OTP, then the user would be able to use this library as standard or 2fa mode without user going out of pipeline to generate tokens.

madhephaestus added a commit to madhephaestus/github-api that referenced this issue Nov 9, 2019
close hub4j#602 by adding an API to request a token using an OTP.
@madhephaestus
Copy link
Contributor Author

I built a snapshot, and implemented it and tested the API generation of tokens when the user has 2fa enabled! (I am very excited about this )

If you merge my PR and publish a new release i can close out all my issues that are stacked up blocked by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant