add lower_case_table_names in gaussdb_mysql #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShiChangkuo
reviewed
Mar 23, 2021
| @@ -294,6 +298,8 @@ func resourceGaussDBInstanceCreate(d *schema.ResourceData, meta interface{}) err | |||
| } | |||
| } | |||
|
|
|||
| lowerCaseTableNames := d.Get("lower_case_table_names").(int) | |||
There was a problem hiding this comment.
the default value will be 0 while it defaults to 1 in the docs, please check this.
Jason-Zhang9309
force-pushed
the
dev-gaussdb
branch
from
5e81a5f to
e9f5902
Compare
ShiChangkuo
reviewed
Mar 24, 2021
| @@ -73,6 +73,10 @@ The following arguments are supported: | |||
| * `enterprise_project_id` - (Optional, String, ForceNew) Specifies the enterprise project id. Required if EPS enabled. | |||
| Changing this parameter will create a new resource. | |||
|
|
|||
| * `lower_case_table_names` - (Optional, Bool) Whether the kernel table name is case sensitive. | |||
There was a problem hiding this comment.
suggest to name it as table_name_case_sensitivity
Jason-Zhang9309
force-pushed
the
dev-gaussdb
branch
from
e9f5902 to
27da478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add lower_case_table_names in gaussdb_mysql
Which issue this PR fixes:
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)fixes #xxx
Special notes for your reviewer:
Release note:
PR Checklist
Acceptance Steps Performed