add enterprise_project_id to secgroup #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niuzhenguo
reviewed
Oct 27, 2020
| @@ -43,6 +44,18 @@ func ResourceNetworkingSecGroupV2() *schema.Resource { | |||
| Optional: true, | |||
| Computed: true, | |||
| }, | |||
| "vpc_id": { | |||
There was a problem hiding this comment.
better to just remove this parameter.
| opts := securitygroups.CreateOpts{ | ||
| Name: d.Get("name").(string), | ||
| EnterpriseProjectId: GetEnterpriseProjectID(d, config), | ||
| VpcId: d.Get("vpc_id").(string), |
| d.Set("name", security_group.Name) | ||
| d.Set("vpc_id", security_group.VpcId) |
| @@ -155,6 +176,16 @@ resource "huaweicloud_networking_secgroup_v2" "secgroup_1" { | |||
| } | |||
| ` | |||
|
|
|||
| func testAccNetworkingV2SecGroup_epsId() string { | |||
| return fmt.Sprintf(` | |||
| resource "huaweicloud_networking_secgroup_v2" "secgroup_1" { | |||
There was a problem hiding this comment.
better to remove the resource version v2
ShiChangkuo
reviewed
Oct 27, 2020
| @@ -98,28 +116,40 @@ func resourceNetworkingSecGroupV2Create(d *schema.ResourceData, meta interface{} | |||
|
|
|||
| d.SetId(security_group.ID) | |||
|
|
|||
| description := d.Get("description").(string) | |||
| networkingClient3, err := config.NetworkingV2Client(GetRegion(d, config)) | |||
There was a problem hiding this comment.
maybe we can have more meaningful names rather than networkingClient2 and networkingClient3
Jason-Zhang9309
force-pushed
the
dev-eps-sg
branch
from
6bb38ab to
f6bfdc4
Compare
|
Related to #435 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testacc TEST='./huaweicloud' TESTARGS='-run TestAccNetworkingV2SecGroup_withEpsId'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccNetworkingV2SecGroup_withEpsId -timeout 360m
=== RUN TestAccNetworkingV2SecGroup_withEpsId
--- PASS: TestAccNetworkingV2SecGroup_withEpsId (18.94s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 18.992s