Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workspace): add new data source to query service detail #6055

Merged

Conversation

Lance52259
Copy link
Contributor

@Lance52259 Lance52259 commented Dec 18, 2024

What this PR does / why we need it:
Supports a new data source that used to query the service configuration.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. add new data source to query service detail.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o workspace -f TestAccDataSourceService_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataSourceService_basic -timeout 360m -parallel 10
=== RUN   TestAccDataSourceService_basic
--- PASS: TestAccDataSourceService_basic (638.82s)
PASS
coverage: 6.5% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 638.875s        coverage: 6.5% of statements in ./huaweicloud/services/workspace
  • Documentation updated.
  • Schema updated.
  • CheckDeleted.

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_workspace_data_service branch 3 times, most recently from fff53ae to 73f4030 Compare December 20, 2024 06:36
@Lance52259 Lance52259 force-pushed the br_workspace_data_service branch from 73f4030 to dc1fc7d Compare December 20, 2024 06:40
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 20, 2024
@github-ci-robot github-ci-robot merged commit 303c85e into huaweicloud:master Dec 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants