Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live/geo_blockings): support live geo blockings dataSource #6036

Conversation

jinyangyang222
Copy link
Contributor

@jinyangyang222 jinyangyang222 commented Dec 16, 2024

What this PR does / why we need it:

Support live geo blockings dataSource

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


Support live geo blockings dataSource

PR Checklist

  • Tests added/passed.
$ export HW_LIVE_STREAMING_DOMAIN_NAME=xxxxxxx

$ make testacc TEST="./huaweicloud/services/acceptance/live" TESTARGS="-run TestAccDataSourceGeoBlockings_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/live -v -run TestAccDataSourceGeoBlockings_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceGeoBlockings_basic
=== PAUSE TestAccDataSourceGeoBlockings_basic
=== CONT  TestAccDataSourceGeoBlockings_basic
--- PASS: TestAccDataSourceGeoBlockings_basic (9.99s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      10.049s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@jinyangyang222 jinyangyang222 force-pushed the feat-live/support_geo_blockings_dataSource branch from f18e3ca to c1f6646 Compare December 16, 2024 12:53
@jinyangyang222 jinyangyang222 force-pushed the feat-live/support_geo_blockings_dataSource branch 2 times, most recently from 5933934 to b56559c Compare December 16, 2024 13:05
@jinyangyang222 jinyangyang222 force-pushed the feat-live/support_geo_blockings_dataSource branch from b56559c to 883eeb4 Compare December 17, 2024 01:27
@deer-hang
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @deer-hang

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit ba2cf60 into huaweicloud:master Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants