Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GaussDB): add gaussdb opengauss datastores data source #6031

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:
add gaussdb opengauss datastores data source
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

  add gaussdb opengauss datastores data source

PR Checklist

  • Tests added/passed.
make testacc TEST=./huaweicloud/services/acceptance/gaussdb/ TESTARGS='-run TestAccDataSourceGaussdbOpengaussDatastores_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/gaussdb/ -v -run TestAccDataSourceGaussdbOpengaussDatastores_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceGaussdbOpengaussDatastores_basic
=== PAUSE TestAccDataSourceGaussdbOpengaussDatastores_basic
=== CONT  TestAccDataSourceGaussdbOpengaussDatastores_basic
--- PASS: TestAccDataSourceGaussdbOpengaussDatastores_basic (15.64s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/gaussdb   15.686s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @houpeng80

Comment on lines 36 to 37
// TODO: 请参考一下代码完善测试脚本
// 注意以下代码仅供参考,一些复杂类型的字段可能会被遗漏,请与代码详细核对(提交时,请删除本行说明)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// TODO: 请参考一下代码完善测试脚本
// 注意以下代码仅供参考,一些复杂类型的字段可能会被遗漏,请与代码详细核对(提交时,请删除本行说明)

@houpeng80 houpeng80 force-pushed the add_gaussdb_opengauss_datastores_data_source branch from d60da31 to 2c02044 Compare December 16, 2024 12:21
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 17, 2024
@github-ci-robot github-ci-robot merged commit acac067 into huaweicloud:master Dec 17, 2024
13 checks passed
@houpeng80 houpeng80 deleted the add_gaussdb_opengauss_datastores_data_source branch December 17, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants