Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live): support a new resource to manage geo-blocking #6017

Merged

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Dec 13, 2024

What this PR does / why we need it:

Support a new resource to manage geo-blocking.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud' TESTARGS='-run=TestAccSomethingV0_basic'
...
go test -v -coverprofile=coverage_1734072249506_TestAccResourceGeoBlocking_basic.cov -coverpkg=./huaweicloud/services/live ./huaweicloud/services/acceptance/live -run TestAccResourceGeoBlocking_basic -timeout 360m -parallel 4
=== RUN   TestAccResourceGeoBlocking_basic
=== PAUSE TestAccResourceGeoBlocking_basic
=== CONT  TestAccResourceGeoBlocking_basic
--- PASS: TestAccResourceGeoBlocking_basic (16.03s)
PASS
coverage: 8.5% of statements in ./huaweicloud/services/live
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/live      16.090s coverage: 8.5% of statements in ./huaweicloud/services/live

image

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      image

      ab. Related resources (parent resources) not found

image

  • b. During delete/disassociate/unbind operation (Delete Context)
    ba. Resource not found
    image

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang deer-hang force-pushed the resource-live-geo-blocking branch 2 times, most recently from eae0b88 to 3fde80f Compare December 13, 2024 06:53
@deer-hang deer-hang force-pushed the resource-live-geo-blocking branch from 3fde80f to e374d2e Compare December 13, 2024 06:56
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 13, 2024
@github-ci-robot github-ci-robot merged commit 1eca631 into huaweicloud:master Dec 13, 2024
13 checks passed
@deer-hang deer-hang deleted the resource-live-geo-blocking branch December 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants