Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add enterprise_project_id to dcs, nat_gateway #601

Merged
merged 1 commit into from
Oct 23, 2020
Merged

add enterprise_project_id to dcs, nat_gateway #601

merged 1 commit into from
Oct 23, 2020

Conversation

Jason-Zhang9309
Copy link
Collaborator 

make testacc TEST='./huaweicloud' TESTARGS='-run TestAccDcsInstancesV1_withEpsId'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccDcsInstancesV1_withEpsId -timeout 360m
=== RUN   TestAccDcsInstancesV1_withEpsId
--- PASS: TestAccDcsInstancesV1_withEpsId (358.14s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       358.191s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccNatGateway_withEpsId -timeout 360m
=== RUN   TestAccNatGateway_withEpsId
--- PASS: TestAccNatGateway_withEpsId (78.40s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       78.441s

ShiChangkuo
ShiChangkuo reviewed Oct 22, 2020
View reviewed changes
huaweicloud/endpoints.go Outdated
Comment on lines 125 to 131
Name: "nat",
Version: "v2.0",
WithOutProjectID: true,
Name: "nat",
Version: "v2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acceptance test TestAccServiceEndpoints_Network also should be updated.

huaweicloud/resource_huaweicloud_dcs_instance_v1.go
ForceNew: true,
Computed: true,
},
"enterprise_project_name": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest to only use enterprise_project_id to keep consistent with other resources.

@ShiChangkuo ShiChangkuo merged commit ff2b57b into huaweicloud:master Oct 23, 2020
@ShiChangkuo
Copy link
Collaborator

Related to #435

@Jason-Zhang9309 Jason-Zhang9309 deleted the dev-eps-id-dcs-and-nat branch October 26, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiChangkuo ShiChangkuo ShiChangkuo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jason-Zhang9309 @ShiChangkuo