Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(servicestage): adjust the script of update phase and do not update name #6008

Conversation

Lance52259
Copy link
Contributor

What this PR does / why we need it:
The name cannot be updated and we don't know why update method doesn't worked.
So skip the name test and check the other parameters update logic to instead.
3dbcaf1f383b7daf050447149ccadf9

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1. adjust the script of update phase and do not update name.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o servicestage -f TestAccComponent_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/servicestage" -v -coverprofile="./huaweicloud/services/acceptance/servicestage/servicestage_coverage.cov" -coverpkg="./huaweicloud/services/servicestage" -run TestAccComponent_basic -timeout 360m -parallel 10
=== RUN   TestAccComponent_basic
=== PAUSE TestAccComponent_basic
=== CONT  TestAccComponent_basic
--- PASS: TestAccComponent_basic (17.05s)
PASS
coverage: 7.9% of statements in ./huaweicloud/services/servicestage
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/servicestage      17.103s coverage: 7.9% of statements in ./huaweicloud/services/servicestage
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @Lance52259

@Lance52259 Lance52259 force-pushed the br_servicestage_acceptance_test_fix branch from 0e752fc to 580c6a3 Compare December 12, 2024 09:46
@deer-hang
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 12, 2024
@github-ci-robot github-ci-robot merged commit 47e1520 into huaweicloud:master Dec 12, 2024
10 checks passed
@Lance52259 Lance52259 deleted the br_servicestage_acceptance_test_fix branch December 17, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. LGTM /lgtm size/XS test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants