Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfw): CFW acl rule support applications field #6006

Merged

Conversation

profoundwu
Copy link
Contributor

@profoundwu profoundwu commented Dec 12, 2024

What this PR does / why we need it:
CFW acl rule support applications field
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

1.  CFW acl rule support  applications field

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/cfw" TESTARGS="-run TestAccACLRule_*"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/cfw -v -run TestAccACLRule_* -timeout 360m -parallel 4
=== RUN   TestAccACLRule_basic
=== PAUSE TestAccACLRule_basic
=== RUN   TestAccACLRule_serviceGroups_regionList
=== PAUSE TestAccACLRule_serviceGroups_regionList
=== RUN   TestAccACLRule_domainAddressName_domainGroup
=== PAUSE TestAccACLRule_domainAddressName_domainGroup
=== RUN   TestAccACLRule_addressGroups
=== PAUSE TestAccACLRule_addressGroups
=== CONT  TestAccACLRule_basic
=== CONT  TestAccACLRule_domainAddressName_domainGroup
=== CONT  TestAccACLRule_addressGroups
=== CONT  TestAccACLRule_serviceGroups_regionList
--- PASS: TestAccACLRule_basic (263.72s)
--- PASS: TestAccACLRule_serviceGroups_regionList (457.83s)
--- PASS: TestAccACLRule_addressGroups (674.35s)
--- PASS: TestAccACLRule_domainAddressName_domainGroup (680.27s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/cfw       680.331s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@profoundwu profoundwu force-pushed the feat_cfw_rule_applications branch 2 times, most recently from a330aeb to f61221d Compare December 12, 2024 10:43
@@ -91,6 +91,12 @@ func ResourceAclRule() *schema.Resource {
Description: `Whether to support persistent connections.`,
ValidateFunc: validation.IntInSlice([]int{0, 1}),
},
"applications": {
Type: schema.TypeList,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the type to set?

@profoundwu profoundwu force-pushed the feat_cfw_rule_applications branch from f61221d to a4fc513 Compare December 12, 2024 12:19
@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 13, 2024
@Jason-Zhang9309
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Jason-Zhang9309

/approve

@github-ci-robot github-ci-robot merged commit e365479 into huaweicloud:master Dec 13, 2024
14 checks passed
@profoundwu profoundwu deleted the feat_cfw_rule_applications branch January 9, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants