Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aom): add ep id in cloud service access request body #5993

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix(aom): add ep id in cloud service access request body #5993

merged 1 commit into from
Dec 13, 2024

Conversation

saf3dfsa
Copy link
Contributor

@saf3dfsa saf3dfsa commented Dec 10, 2024 •
edited
Loading

What this PR does / why we need it:
add ep_id in cloud service access request body
fix update, add id in request body

PR Checklist

  • Tests added/passed.
make testacc TEST="./huaweicloud/services/acceptance/aom" TESTARGS="-run TestAccCloudServiceAccess_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/aom -v -run TestAccCloudServiceAccess_basic -timeout 360m -parallel 4
=== RUN   TestAccCloudServiceAccess_basic
=== PAUSE TestAccCloudServiceAccess_basic
=== CONT  TestAccCloudServiceAccess_basic
--- PASS: TestAccCloudServiceAccess_basic (51.85s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/aom       51.921s

  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@saf3dfsa saf3dfsa force-pushed the fix(aom)_add_ep_id_in_cloud_service_access_request_body branch from bce5429 to 4cb06c5 Compare December 10, 2024 08:29
@saf3dfsa saf3dfsa force-pushed the fix(aom)_add_ep_id_in_cloud_service_access_request_body branch from 4cb06c5 to 09996d5 Compare December 10, 2024 08:39
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 10, 2024
@saf3dfsa saf3dfsa changed the title fix(dom): add ep id in cloud service access request body fix(aom): add ep id in cloud service access request body Dec 12, 2024
@github-actions github-actions bot removed the LGTM /lgtm label Dec 12, 2024
@houpeng80
Copy link
Collaborator

/approve

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
github-ci-robot
github-ci-robot approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @houpeng80

/approve

@houpeng80
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Dec 13, 2024
@github-ci-robot github-ci-robot merged commit 2a01a6e into huaweicloud:master Dec 13, 2024
18 checks passed
@saf3dfsa saf3dfsa deleted the fix(aom)_add_ep_id_in_cloud_service_access_request_body branch December 26, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-ci-robot github-ci-robot github-ci-robot approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugfix LGTM /lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saf3dfsa @Jason-Zhang9309 @houpeng80 @github-ci-robot