Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(waf): modify some issues with the waf certificate resource and datasource #5808

Merged

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Nov 4, 2024

What this PR does / why we need it:

  • modify waf certificate datasource and fix some problems.
    • fix some problems in datasource code.
    • support new filter fields in datasource.
    • discard two invalid fields.
    • refactor datasource code to automatically generate styles.
    • supplementary datasource documentation description.
    • improve test case execution efficiency.
  • modify waf certificate resource and fix some problems.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/waf' TESTARGS='-run TestAccDataSourceWafCertificate_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/waf -v -run TestAccDataSourceWafCertificate_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceWafCertificate_basic
=== PAUSE TestAccDataSourceWafCertificate_basic
=== CONT  TestAccDataSourceWafCertificate_basic
--- PASS: TestAccDataSourceWafCertificate_basic (13.15s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/waf       13.191s
make testacc TEST='./huaweicloud/services/acceptance/waf' TESTARGS='-run TestAccWafCertificate_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/waf -v -run TestAccWafCertificate_basic -timeout 360m -parallel 4
=== RUN   TestAccWafCertificate_basic
=== PAUSE TestAccWafCertificate_basic
=== CONT  TestAccWafCertificate_basic
--- PASS: TestAccWafCertificate_basic (18.88s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/waf       18.928s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang deer-hang force-pushed the chore-waf-datasource-certificate branch 2 times, most recently from f21acef to fa2f902 Compare November 5, 2024 02:45
@deer-hang deer-hang force-pushed the chore-waf-datasource-certificate branch from fa2f902 to ee0dfab Compare November 5, 2024 02:49
@github-actions github-actions bot added size/M and removed size/L labels Nov 5, 2024
@github-actions github-actions bot added size/L and removed size/M labels Nov 5, 2024
@deer-hang deer-hang changed the title chore(waf): Modify some issues with the waf certificate datasource chore(waf): modify some issues with the waf certificate resource and datasource Nov 5, 2024
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 5, 2024
@github-ci-robot github-ci-robot merged commit 1a915a3 into huaweicloud:master Nov 5, 2024
22 checks passed
@deer-hang deer-hang deleted the chore-waf-datasource-certificate branch November 5, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants