Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(waf): maintain waf address group resource (datasource) and fix some problems #5807

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Nov 4, 2024

What this PR does / why we need it:

  • maintain waf address groups datasource and fix some problems.
  • maintain waf address group resource and fix some problems.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/waf' TESTARGS='-run TestAccDatasourceWAFAddressGroups_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/waf -v -run TestAccDatasourceWAFAddressGroups_basic -timeout 360m -parallel 4
=== RUN   TestAccDatasourceWAFAddressGroups_basic
=== PAUSE TestAccDatasourceWAFAddressGroups_basic
=== CONT  TestAccDatasourceWAFAddressGroups_basic
--- PASS: TestAccDatasourceWAFAddressGroups_basic (17.81s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/waf       17.892s
make testacc TEST='./huaweicloud/services/acceptance/waf' TESTARGS='-run TestAccAddressGroup_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/waf -v -run TestAccAddressGroup_basic -timeout 360m -parallel 4
=== RUN   TestAccAddressGroup_basic
=== PAUSE TestAccAddressGroup_basic
=== CONT  TestAccAddressGroup_basic
--- PASS: TestAccAddressGroup_basic (16.50s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/waf       16.538s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@deer-hang deer-hang changed the title chore(waf): increase the robustness of waf datasource address groups and fix some issues chore(waf): increase the robustness of waf datasource address groups Nov 4, 2024
@deer-hang deer-hang changed the title chore(waf): increase the robustness of waf datasource address groups chore(waf): increase the robustness of waf datasource address groups Nov 4, 2024
@deer-hang deer-hang force-pushed the chore-waf-datasource-address-groups branch from a916259 to e58c0f0 Compare November 4, 2024 11:51
@github-actions github-actions bot added size/L and removed size/M labels Nov 4, 2024
@deer-hang deer-hang force-pushed the chore-waf-datasource-address-groups branch from 0dc71fc to e0b28d0 Compare November 4, 2024 12:19
@github-actions github-actions bot added size/M and removed size/L labels Nov 4, 2024
@github-actions github-actions bot added size/L and removed size/M labels Nov 4, 2024
@deer-hang deer-hang changed the title chore(waf): increase the robustness of waf datasource address groups chore(waf): maintain waf address group resource (datasource) and fix some problems Nov 4, 2024
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 5, 2024
@github-ci-robot github-ci-robot merged commit fd46bb2 into huaweicloud:master Nov 5, 2024
22 checks passed
@deer-hang deer-hang deleted the chore-waf-datasource-address-groups branch November 5, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants