Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GaussDBforMySQL): add gaussdb mysql engine versions data source #5806

Conversation

houpeng80
Copy link
Collaborator

What this PR does / why we need it:
add gaussdb mysql engine versions data source
Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

  add gaussdb mysql engine versions data source

PR Checklist

  • Tests added/passed.
make testacc TEST=./huaweicloud/services/acceptance/gaussdb/ TESTARGS='-run TestAccDataSourceGaussdbMysqlEngineVersions_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/gaussdb/ -v -run TestAccDataSourceGaussdbMysqlEngineVersions_basic -timeout 360m -parallel 4
=== RUN   TestAccDataSourceGaussdbMysqlEngineVersions_basic
=== PAUSE TestAccDataSourceGaussdbMysqlEngineVersions_basic
=== CONT  TestAccDataSourceGaussdbMysqlEngineVersions_basic
--- PASS: TestAccDataSourceGaussdbMysqlEngineVersions_basic (36.32s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/gaussdb   36.364s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @houpeng80

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@houpeng80 houpeng80 force-pushed the add_gaussdb_mysql_engine_versions_data_source branch from 03b964a to 3446c31 Compare November 4, 2024 02:55
@houpeng80 houpeng80 force-pushed the add_gaussdb_mysql_engine_versions_data_source branch from 3446c31 to 3042e4e Compare November 4, 2024 06:27
@Jason-Zhang9309
Copy link
Collaborator

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 5, 2024
@github-ci-robot github-ci-robot merged commit 4a9061e into huaweicloud:master Nov 5, 2024
13 checks passed
@houpeng80 houpeng80 deleted the add_gaussdb_mysql_engine_versions_data_source branch November 5, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants