Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nat): unify aotumatically code style and fix some error in test cases #5785

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

deer-hang
Copy link
Contributor

@deer-hang deer-hang commented Oct 30, 2024

What this PR does / why we need it:

Unify aotumatically code style and fix some error in test cases.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:


PR Checklist

  • Tests added/passed.
make testacc TEST='./huaweicloud/services/acceptance/nat' TESTARGS='-run TestAccData'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/services/acceptance/nat -v -run TestAccData -timeout 360m -parallel 4
=== RUN   TestAccDatasourceDnatRules_basic
=== PAUSE TestAccDatasourceDnatRules_basic
=== RUN   TestAccDataPublicGateway_basic
=== PAUSE TestAccDataPublicGateway_basic
=== RUN   TestAccDatasourcePublicGateways_basic
=== PAUSE TestAccDatasourcePublicGateways_basic
=== RUN   TestAccDatasourcePrivateDnatRules_basic
=== PAUSE TestAccDatasourcePrivateDnatRules_basic
=== RUN   TestAccDatasourcePrivateGateways_basic
=== PAUSE TestAccDatasourcePrivateGateways_basic
=== RUN   TestAccDatasourcePrivateSnatRules_basic
=== PAUSE TestAccDatasourcePrivateSnatRules_basic
=== RUN   TestAccDatasourcePrivateTransitIps_basic
=== PAUSE TestAccDatasourcePrivateTransitIps_basic
=== RUN   TestAccDatasourceSnatRules_basic
=== PAUSE TestAccDatasourceSnatRules_basic
=== RUN   TestAccDatasourceSnatRules_direct
=== PAUSE TestAccDatasourceSnatRules_direct
=== CONT  TestAccDatasourceDnatRules_basic
=== CONT  TestAccDatasourcePrivateSnatRules_basic
=== CONT  TestAccDatasourcePrivateDnatRules_basic
=== CONT  TestAccDatasourcePrivateGateways_basic
--- PASS: TestAccDatasourcePrivateSnatRules_basic (73.97s)
=== CONT  TestAccDatasourcePublicGateways_basic
--- PASS: TestAccDatasourcePrivateGateways_basic (74.47s)
=== CONT  TestAccDatasourcePrivateTransitIps_basic
--- PASS: TestAccDatasourcePrivateTransitIps_basic (93.52s)
=== CONT  TestAccDatasourceSnatRules_direct
--- PASS: TestAccDatasourcePublicGateways_basic (101.25s)
=== CONT  TestAccDataPublicGateway_basic
--- PASS: TestAccDatasourcePrivateDnatRules_basic (209.62s)
=== CONT  TestAccDatasourceSnatRules_basic
--- PASS: TestAccDatasourceDnatRules_basic (215.55s)
--- PASS: TestAccDataPublicGateway_basic (77.17s)
--- PASS: TestAccDatasourceSnatRules_direct (86.45s)
--- PASS: TestAccDatasourceSnatRules_basic (84.17s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/nat       293.833s
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@github-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This PR has been approved by: @deer-hang

@github-ci-robot github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@github-actions github-actions bot added the chore label Oct 30, 2024
@deer-hang deer-hang changed the title chore(nat): unify aotumatically code style and increase the scope of test case testing chore(nat): unify aotumatically code style and fix some error in test cases Oct 30, 2024
@jinyangyang222
Copy link
Contributor

/lgtm

@github-ci-robot github-ci-robot added the LGTM /lgtm label Nov 1, 2024
@github-ci-robot github-ci-robot merged commit b7ca13f into huaweicloud:master Nov 1, 2024
19 checks passed
@deer-hang deer-hang deleted the chore-nat-code branch November 1, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chore LGTM /lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants