Add data source of obs bucket object #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilemusic
force-pushed
the
obs-object
branch
3 times, most recently
from
f947030 to
85c9055
Compare
niuzhenguo
reviewed
Aug 27, 2020
huaweicloud/provider.go
Outdated
| @@ -244,6 +244,7 @@ func Provider() terraform.ResourceProvider { | |||
| "huaweicloud_identity_role_v3": dataSourceIdentityRoleV3(), | |||
| "huaweicloud_cdm_flavors_v1": dataSourceCdmFlavorV1(), | |||
| "huaweicloud_dis_partition_v2": dataSourceDisPartitionV2(), | |||
| "huaweicloud_obs_bucket_object": dataSourceObsBucketObject(), | |||
There was a problem hiding this comment.
Please move this to L202.
ok
niuzhenguo
reviewed
Aug 27, 2020
smilemusic
force-pushed
the
obs-object
branch
2 times, most recently
from
efdb20c to
af82f44
Compare
ShiChangkuo
reviewed
Aug 27, 2020
Comment on lines
18
to
21
| "body": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
the recommended order in Schema: Required --> Optional --> Computed
Comment on lines
89
to
95
| if resp.Body != nil { | ||
| body, err := ioutil.ReadAll(resp.Body) | ||
| if err != nil { | ||
| return getObsError("Error get body of OBS bucket object", bucket, err) | ||
| } | ||
| d.Set("body", string(body)) | ||
| } |
There was a problem hiding this comment.
The content of an object maybe very large, please do some test on a huge object, thanks
| "github.com/huaweicloud/golangsdk/openstack/obs" | ||
| ) | ||
|
|
||
| func TestAccHuaweiCloudObsBucketObjectDataSource_content(t *testing.T) { |
There was a problem hiding this comment.
seems the TestAccHuaweiCloudObsBucketObjectDataSource_content and TestAccHuaweiCloudObsBucketObjectDataSource_source are the same testing case for data source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testacc TEST=./huaweicloud/ TESTARGS='-run TestAccDataSourceAWSObsBucketObject_allParams'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/ -v -run TestAccDataSourceAWSObsBucketObject_allParams -timeout 360m
=== RUN TestAccDataSourceAWSObsBucketObject_allParams
--- PASS: TestAccDataSourceAWSObsBucketObject_allParams (17.63s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 17.662s
make testacc TEST=./huaweicloud/ TESTARGS='-run TestAccDataSourceObsBucketObject_source'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud/ -v -run TestAccDataSourceObsBucketObject_source -timeout 360m
=== RUN TestAccDataSourceObsBucketObject_source
--- PASS: TestAccDataSourceObsBucketObject_source (17.18s)
PASS
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud 17.761s