Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore error when fetching tags failed in ReadFunc #332

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

ShiChangkuo
Copy link
Collaborator

fixes #331

@ghost ghost added the size/S label May 29, 2020
if err := d.Set("tags", tagmap); err != nil {
return fmt.Errorf("Error saving tags for HuaweiCloud VirtualPrivateCloud (%s): %s", d.Id(), err)
if _, ok := err.(golangsdk.ErrDefault404); ok {
log.Printf("[INFO] fetching VPC %s tags failed: The API does not exist or has not been published", d.Id())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@niuzhenguo niuzhenguo merged commit d2fc663 into huaweicloud:master Jun 1, 2020
@ShiChangkuo ShiChangkuo deleted the resource_tags branch July 6, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raising an error message when refreshing vpc and subnet
2 participants