Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data source iam role #16

Merged
merged 2 commits into from
Jul 20, 2018
Merged

Conversation

zengchen1024
Copy link
Contributor

@zengchen1024 zengchen1024 commented Jul 20, 2018

=== RUN TestAccIAMRoleV3DataSource_basic
--- PASS: TestAccIAMRoleV3DataSource_basic (17.38s)
PASS
ok github.com/terraform-providers/terraform-provider-huaweicloud/huaweicloud 17.388s

@zengchen1024
Copy link
Contributor Author

@niuzhenguo Could you take a look at this pr. thanks!

@niuzhenguo
Copy link
Member

@zengchen1024 Please also help to update the CHANGELOG to include the new resources as 551eba2

@zengchen1024
Copy link
Contributor Author

@niuzhenguo Done

CHANGELOG.md Outdated
@@ -19,6 +19,7 @@ FEATURES:
* **New Data Source:** `huaweicloud_kms_key_v1`
* **New Data Source:** `huaweicloud_kms_data_key_v1`
* **New Data Source:** `huaweicloud_rds_flavors_v1`
* **New Data Source:** `huaweicloud_iam_role_v3`
Copy link
Member

@niuzhenguo niuzhenguo Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1.0.0 is already released! this should be added under v1.1.0 above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@niuzhenguo niuzhenguo merged commit 784ae26 into huaweicloud:master Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants