Add Vpc , Vpc peering, Route, Subnet #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please resolve conflicts and update CHANGELOG, thanks! |
|
Done |
niuzhenguo
reviewed
Jul 24, 2018
| log.Printf("[INFO] Vpc Subnet ID: %s", n.ID) | ||
|
|
||
| stateConf := &resource.StateChangeConf{ | ||
| Pending: []string{"CREATING"}, |
There was a problem hiding this comment.
According to the API doc and feedbacks from users, "UNKNOWN" should be included as Pending status, and seems there's no a status "CREATING".
| vpc_id := d.Get("vpc_id").(string) | ||
|
|
||
| stateConf := &resource.StateChangeConf{ | ||
| Pending: []string{"ACTIVE"}, |
|
|
||
| //If subnet status is other than Active, send error | ||
| if n.Status == "DOWN" || n.Status == "ERROR" || n.Status == "UNKNOWN" { | ||
| return nil, "", fmt.Errorf("Subnet status: '%s'", n.Status) |
There was a problem hiding this comment.
UNKNOWN here is a normal status.
niuzhenguo
reviewed
Jul 24, 2018
| "github.com/hashicorp/terraform/helper/resource" | ||
| ) | ||
|
|
||
| // PASS |
There was a problem hiding this comment.
Please help to clean up such test results "// PASS"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a capability to manage Huawei's VPC Peering Connection, Routes, Vpc, and Subnets.