Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for timestamps #27

Closed
wants to merge 3 commits into from
Closed

add support for timestamps #27

wants to merge 3 commits into from

Conversation

Lazyshot
Copy link
Contributor

No description provided.

@huandu
Copy link
Owner

huandu commented Mar 18, 2015

@Lazyshot Thanks for your contribution!

A review comment: Use reflect.Type#ConvertibleTo to check whether the field type is time.Time instead of using names.

One may redefine the type, e.g. type MyTime time.Time. Your way will fail in this case.

@Lazyshot
Copy link
Contributor Author

I've added support for the custom timestamp type and test.

@huandu
Copy link
Owner

huandu commented Mar 19, 2015

I've manually squashed and merged your commits into master. Thanks for your contribution again!

@huandu huandu closed this Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lazyshot @huandu