From aff34f74aea3aa58a743a03883f0ec82743276dd Mon Sep 17 00:00:00 2001 From: Vitor Enes Date: Tue, 23 Feb 2021 12:58:53 +0000 Subject: [PATCH] Allow a conn open ack to succeed in the happy case (#700) * Allow a conn open ack to succeed * Remove invalid test * update CHANGELOG * Make MsgConnectionOpenAck.counterparty_connection_id not an Option --- CHANGELOG.md | 5 ++++- relayer/src/connection.rs | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d5c63e31dd..4d6aac175d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -34,6 +34,7 @@ - [ibc] - Fix overflow bug in ICS03 client consensus height verification method ([#685]) + - Allow a conn open ack to succeed in the happy case ([#699]) - [ibc-relayer] - [nothing yet] @@ -44,7 +45,7 @@ ### BREAKING CHANGES - [ibc] - - [nothing yet] + - `MsgConnectionOpenAck.counterparty_connection_id` is now a `ConnectionId` instead of an `Option`([#700]) - [ibc-relayer] - [nothing yet] @@ -55,6 +56,8 @@ [#599]: https://github.com/informalsystems/ibc-rs/issues/599 [#685]: https://github.com/informalsystems/ibc-rs/issues/685 [#689]: https://github.com/informalsystems/ibc-rs/issues/689 +[#699]: https://github.com/informalsystems/ibc-rs/issues/699 +[#700]: https://github.com/informalsystems/ibc-rs/pull/700 ## v0.1.1 *February 17, 2021* diff --git a/relayer/src/connection.rs b/relayer/src/connection.rs index 2b23a3e9a6..7e56bc8abc 100644 --- a/relayer/src/connection.rs +++ b/relayer/src/connection.rs @@ -566,7 +566,7 @@ impl Connection { let new_msg = MsgConnectionOpenAck { connection_id: self.dst_connection_id().clone(), - counterparty_connection_id: Option::from(self.src_connection_id().clone()), + counterparty_connection_id: self.src_connection_id().clone(), client_state, proofs, version: src_connection.versions()[0].clone(),