Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#connect_ssl influenced by read/write timeouts, not connect #359

Closed
HoneyryderChuck opened this issue Jul 20, 2016 · 0 comments
Closed

#connect_ssl influenced by read/write timeouts, not connect #359

HoneyryderChuck opened this issue Jul 20, 2016 · 0 comments

Comments

@HoneyryderChuck
Copy link

https://github.com/httprb/http/blob/master/lib/http/timeout/per_operation.rb#L30-L36

The rescue's seem ok, problem is the timeout used underneath. The correct timeout in this case should be connect_timeout, but in both blocks two different timeouts will be used.

This could be easily handled if the rescue_ methods would accept a timeout parameter which would overwrite the default IMO.

tarcieri added a commit that referenced this issue Aug 9, 2016
connect_ssl uses connect_timeout (Closes #359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant