Honor .Netrc when --auth-type is used #934
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nb2838 Going through this realized there was a bunch of netrc-related issues. So I made a bigger commit addressing them all all. I cherry-picked the test you wrote. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added code so that httpie honors .netrc when --auth-type is used. This was done by explicitly handling the .netrc rather than implicitly leaving it to the requests library. Maybe it would be good to in the future disallow reading the .netrc if the file has too many permissions as is done with some applications (this is also the default behaviour of the python library.) I also added a test to check that the behaviour does work.
#852