Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for XML formatting #1129

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Add support for XML formatting #1129

merged 1 commit into from
Aug 31, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Aug 17, 2021

Slightly inspired from #720, it explains the credits.
Closes #825.

XML test files are from the defused repository.

As a side effect, XHTML responses will be pretty-printed too.

@BoboTiG BoboTiG requested a review from jkbrzt August 17, 2021 14:53
@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #1129 (d7deb04) into master (8618f12) will increase coverage by 0.00%.
The diff coverage is 97.26%.

❗ Current head d7deb04 differs from pull request most recent head 65a1768. Consider uploading reports for the commit 65a1768 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   97.17%   97.17%           
=======================================
  Files          65       67    +2     
  Lines        4170     4243   +73     
=======================================
+ Hits         4052     4123   +71     
- Misses        118      120    +2     
Impacted Files Coverage Δ
httpie/cli/constants.py 100.00% <ø> (ø)
tests/test_output.py 99.47% <ø> (ø)
httpie/output/formatters/xml.py 97.05% <97.05%> (ø)
tests/test_xml.py 97.14% <97.14%> (ø)
httpie/plugins/registry.py 100.00% <100.00%> (ø)
tests/fixtures/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8618f12...65a1768. Read the comment docs.

httpie/output/formatters/xml.py Outdated Show resolved Hide resolved
tests/fixtures/__init__.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
httpie/output/formatters/xml.py Outdated Show resolved Hide resolved
@BoboTiG BoboTiG changed the title Add back the XML formatter Add support for XML formatting Aug 23, 2021
@BoboTiG BoboTiG requested a review from jkbrzt August 25, 2021 09:46
As a side effect, XHTML responses will be pretty-printed too.
@jkbrzt jkbrzt merged commit d10e108 into httpie:master Aug 31, 2021
@BoboTiG BoboTiG deleted the mickael/dev-214-resurrect-the-xml-formatter branch September 1, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add option to reformat XML body
3 participants