Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (#998): Will not expire/delete cookie from session when Set-Cookie only sets Max-Age=0 without Expires #1029

Merged
merged 5 commits into from
Feb 6, 2021

Conversation

luckydenis
Copy link
Contributor

Summary:
The reason why the cookie state information is lost is that when a response is received, the query library does not process max-age=0. It was decided to report the problem to the requests community and implement a temporary solution.

Done:

@codecov-io
Copy link

codecov-io commented Feb 5, 2021

Codecov Report

Merging #1029 (d4e57b2) into master (cf78a12) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
+ Coverage   95.55%   95.56%   +0.01%     
==========================================
  Files          61       61              
  Lines        3937     3947      +10     
==========================================
+ Hits         3762     3772      +10     
  Misses        175      175              
Impacted Files Coverage Δ
httpie/utils.py 97.72% <100.00%> (+0.35%) ⬆️
tests/test_sessions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf78a12...d4e57b2. Read the comment docs.

@luckydenis
Copy link
Contributor Author

It looks like there was a bug in the test environment. 😊

httpie/utils.py Show resolved Hide resolved
@jkbrzt jkbrzt merged commit 3c07a25 into httpie:master Feb 6, 2021
jkbrzt added a commit that referenced this pull request Feb 6, 2021
@jkbrzt
Copy link
Member

jkbrzt commented Feb 6, 2021

Thanks, @luckydenis 🥧

@luckydenis
Copy link
Contributor Author

@jakubroztocil, Thank you, I hope to participate in your wonderful project again ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants