Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What else belongs in sbt-http4s-org? #121

Closed
1 of 4 tasks
armanbilge opened this issue Jan 10, 2022 · 2 comments
Closed
1 of 4 tasks

What else belongs in sbt-http4s-org? #121

armanbilge opened this issue Jan 10, 2022 · 2 comments

Comments

@armanbilge
Copy link
Member

armanbilge commented Jan 10, 2022

Spinning out of #120 (review).

The forthcoming sbt-typelevel will lighten the current load of this plugin considerably. However, we are on the verge of a schism, so we will have to re-locate shared settings in http4s proper to here.

@rossabaker
Copy link
Member

Regarding "this stuff":

  • initCommands is a failure. It pulls in some prominent dependencies, but it's still not an http4s REPL per se. I'd rather have a dev shell with a scala-cli that includes the batteries.
  • the misplaced sources check seems upstreamable?
  • the module name prefix is hardly worth it
  • I guess the default test library set is nice.

By the time things get properly upstreamed, I am still hopeful this plugin can be retired.

@armanbilge
Copy link
Member Author

Scalafixes are being upstreamed and many modules schismed without "this stuff". So I reckon we're good.

By the time things get properly upstreamed, I am still hopeful this plugin can be retired.

I don't see how this can happen so long as we want a unified website theme for the org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants