Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish series/0.2 against sjs-dom 2.x #28

Merged
merged 13 commits into from
Oct 28, 2021

Conversation

armanbilge
Copy link
Member

@armanbilge armanbilge commented Oct 24, 2021

This establishes http4s-dom series/0.2 which will publish against scala-js-dom 2.x. It will also add support for Scala 3.1.

If anyone feels strongly about a strategy like #15 instead of branching, feel free to make a proposal. I'm not sure it's worth the complexity, and it would be different than what http4s proper and http4s-jdk-http-client are doing.

Instead, my proposal is we do all new feature development on this branch (if anyone wants to work on that!) and only do bug/security fixes for series/0.1 if they come up.

Most of the major scalajs projects are moving to sjs-dom 2.x anyway:

@armanbilge armanbilge linked an issue Oct 24, 2021 that may be closed by this pull request
@armanbilge armanbilge mentioned this pull request Oct 24, 2021
@armanbilge
Copy link
Member Author

I'm going to move forward with this, nothing controversial here, just a dependency update.

@armanbilge armanbilge merged commit 306a00d into http4s:series/0.2 Oct 28, 2021
Copy link
Collaborator

@rpiaggio rpiaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, we've been swamped these past few weeks.

I have no strong feelings about using projectmatrix but I must say I like the idea more each day. Anyway, we are already branching here and LGTM.

@armanbilge
Copy link
Member Author

Thanks, we can always switch to project matrix at a later time as well. But whenever I do the mental math, using project matrix here only makes sense if:

  • there is development on series 0.1, and
  • this happens more than X times, where X is enough times that merging a branch is annoying :)

Actually I'll be happy to be wrong about this, if it means people are actively developing and using this lib 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish for Scala 3
2 participants