-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish series/0.2 against sjs-dom 2.x #28
Establish series/0.2 against sjs-dom 2.x #28
Conversation
I'm going to move forward with this, nothing controversial here, just a dependency update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, we've been swamped these past few weeks.
I have no strong feelings about using projectmatrix but I must say I like the idea more each day. Anyway, we are already branching here and LGTM.
Thanks, we can always switch to project matrix at a later time as well. But whenever I do the mental math, using project matrix here only makes sense if:
Actually I'll be happy to be wrong about this, if it means people are actively developing and using this lib 😆 |
This establishes http4s-dom series/0.2 which will publish against scala-js-dom 2.x. It will also add support for Scala 3.1.
If anyone feels strongly about a strategy like #15 instead of branching, feel free to make a proposal. I'm not sure it's worth the complexity, and it would be different than what http4s proper and http4s-jdk-http-client are doing.
Instead, my proposal is we do all new feature development on this branch (if anyone wants to work on that!) and only do bug/security fixes for series/0.1 if they come up.
Most of the major scalajs projects are moving to sjs-dom 2.x anyway:
2.0.0
com-lihaoyi/scalatags#225