Update to sjs-dom 2.0.0 #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
commented
Oct 17, 2021
build.sbt
Outdated
| @@ -125,7 +125,8 @@ lazy val dom = project | |||
| "co.fs2" %%% "fs2-core" % fs2Version, | |||
| "org.http4s" %%% "http4s-client" % http4sVersion, | |||
| "org.scala-js" %%% "scalajs-dom" % scalaJSDomVersion | |||
| ) | |||
| ), | |||
| dependencyOverrides += "org.scala-js" %%% "scalajs-dom" % scalaJSDomVersion | |||
There was a problem hiding this comment.
Workaround pending typelevel/fs2#2681.
|
typelevel/fs2#2681 really shot us in the foot ... |
cquiroz
reviewed
Oct 18, 2021
| import org.scalajs.dom.experimental.ResponseInit | ||
| import org.scalajs.dom.experimental.serviceworkers.FetchEvent | ||
| import org.scalajs.dom.experimental.serviceworkers.ServiceWorkerGlobalScope | ||
| import org.scalajs.dom.experimental.{Response => DomResponse} |
There was a problem hiding this comment.
Why were they renamed upstream? Were they experimental on the scala.js side or were they experimental originally on the dom side?
There was a problem hiding this comment.
They were experimental in DOM. But in general, in SJS-dom we decided to "de-namespace": almost everything is inside the dom.* package now. See this for details.
cquiroz
approved these changes
Oct 18, 2021
|
Thanks! But this is badly broken until typelevel/fs2#2681 is fixed. I mostly opened this to check that the sjs-dom RC is working ok. We still need to decide what our branching strategy is going to be. |
This was referenced Oct 21, 2021
|
Superseded by #28. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.