Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nightly build #25

Merged
merged 1 commit into from
Aug 12, 2019
Merged

fix nightly build #25

merged 1 commit into from
Aug 12, 2019

Conversation

miller-time
Copy link
Contributor

@miller-time miller-time commented Aug 2, 2019

This crate and crates that depend on it (e.g. iron -> docs.rs) have been unable to build on nightly since nightly-2019-08-02 due to unstabilizing #[bench] - rust-lang/rust#62507

error[E0658]: use of unstable library feature 'test': `bench` is a part of custom test frameworks which are unstable

#[bench]
  ^^^^^
 help: add `#![feature(test)]` to the crate attributes to enable

@Nemo157
Copy link
Contributor

Nemo157 commented Aug 9, 2019

Till this is merged you can patch the dependency:

[patch.crates-io.route-recognizer]
git = "https://github.com/miller-time/route-recognizer.rs"
rev = "d7bc06d2dc58a2c59d8f2cfbee2ab23b8188700d"

miller-time added a commit to miller-time/router that referenced this pull request Aug 9, 2019
I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
miller-time added a commit to miller-time/router that referenced this pull request Aug 9, 2019
I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
miller-time added a commit to miller-time/router that referenced this pull request Aug 9, 2019
closes iron#148

- use patch for route-recognizer
- add `dyn` to trait objects

I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
HeroicKatora added a commit to HeroicKatora/oxide-auth that referenced this pull request Aug 10, 2019
@Nemo157 Nemo157 merged commit 76d4c85 into http-rs:master Aug 12, 2019
miller-time added a commit to miller-time/router that referenced this pull request Aug 13, 2019
closes iron#148

- use patch for route-recognizer
- add `dyn` to trait objects

I guess route-recognizer is no longer maintained? My PR:
http-rs/route-recognizer#25
Comment from Alex Crichton:
http-rs/route-recognizer#26 (comment)
HeroicKatora added a commit to HeroicKatora/oxide-auth that referenced this pull request Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants