Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: shrink down test file #442

Merged
merged 4 commits into from
Jun 1, 2020
Merged

Conversation

Shinigami92
Copy link
Contributor

Short description of what this resolves:

Currently there is a bug in nodejs which affects macos
nodejs/node#19218

To get around this, some tests need to be compared to a file that generates fewer hint errors

Proposed changes:

Test against a file with less hints

@Shinigami92 Shinigami92 self-assigned this Jun 1, 2020
Copy link
Member

@thedaviddias thedaviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Shinigami92 Shinigami92 merged commit d6e5861 into master Jun 1, 2020
@Shinigami92 Shinigami92 deleted the test/shrink-down-test-file branch June 1, 2020 20:18
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.15.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@thedaviddias thedaviddias added the released on @beta The issue was released on the beta branch label Jun 25, 2020
@thedaviddias
Copy link
Member

🎉 This PR is included in version 0.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @beta The issue was released on the beta branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants