Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few suggestions to aid understanding #25

Open
amyheather opened this issue May 2, 2024 · 0 comments
Open

A few suggestions to aid understanding #25

amyheather opened this issue May 2, 2024 · 0 comments

Comments

@amyheather
Copy link

amyheather commented May 2, 2024

Hello, these are a few suggestions of sections where I was unclear on something, or thought people could find something unclear.

1 - Introduction to DES Concepts

  • When first state “In a stochastic model”, not yet introduced what stochastic means

3 - An Introduction to SimPy

  • Not sure what the “For 1” and “For 2” section under “Let’s imagine we are modelling patients in a patient pathway.” is referring to. I'm presuming it might be referring to a previous example not on this page?

17 - Tracking Resource Utilisation

  • 17.2.1.3.2 - run_trial method doesn't currently have description of what was changed

23 - Dealing with Appointment Bookings

  • 23.2.1. - End of sentence missing - "In the final new parameter, we will"
  • 23.2.2 - "We will also create a space to record the time patients arrive into the model, and the time they have their appointment." - for the latter, I initially interrupted that to mean appointment time, but can see it is referring to queue time / waiting time (so e.g. "time they have to wait until they have their appointment" perhaps?)
  • 23.2.3 - As there is a lot of new code in this section, I might suggest directly referring to particular functions in the markdown description (e.g. that create_slots() does this part... and create_bookings() does that part). Also perhaps adding a few more comments for both those functions within the code?
  • 23.2.5.2 - Perhaps to add some markdown description of what has changed

27 - Parallelisation

  • 27.1 - I would perhaps mention why we have Parallel and delayed? This was something I went away and googled whilst reading through, and found it really helpful to understand. From this stackoverflow post, I could see that the delayed() function as it prevents the function from running. If we just had Parallel(n_jobs=2)(multiply_by_self)(i) for i in range(1, 11, 1)), by the time it gets passed to Paralell, the multiply_by_self(i) calls have already returned, and there's nothing left to execute in Parallel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant