add <Polygon /> to vx-shape #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Don’t want to leave you in suspense, I’m just traveling and away from computer until Monday. Will take a look then. |
|
Hi @hshoff any thoughts on this? |
hshoff
reviewed
Sep 18, 2018
packages/vx-shape/Readme.md
Outdated
| | Name | Default | Type | Description | | ||
| | :-------------- | :----------------------- | :------- | :--------------------------------------------------------------------------------------------- | | ||
| | sides | | number | The number of sides in the polygon. | | ||
| | size | 25 | number | The length of eacch side of the polygon. | |
hshoff
reviewed
Sep 18, 2018
| points={points} | ||
| className={className} | ||
| fill={fill} | ||
| onClick={clickHandler} |
There was a problem hiding this comment.
Let's remove the clickHandler prop. In vx land you would just pass onClick and it would pass through in {...restProps}
hshoff
reviewed
Sep 18, 2018
hshoff
requested changes
Sep 18, 2018
hshoff
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Enhancements
I have added a new simple
<Polygon />component that takessidesandlengthprops and does the rest. I have added it tovx-shape📝 Documentation
I have added a demo to
vx-demoand updated the vx-shape README