Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] add sideEffects: false to pkg for webpack 4 #225

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

hshoff
Copy link
Member

@hshoff hshoff commented Jan 12, 2018

🏠 Internal

  • [internal] add sideEffects: false to pkg for webpack 4

In preparation for webpack 4, this change will tell webpack to it's safe to prune unused exports.

This benefits developers using webpack for perf gains in the form of smaller bundle sizes.

Until webpack 4 is out, it's preferred to import from the deep path for vx users (only include what you use in your build vs including the entire lib index).

import AxisBottom from '@vx/axis/build/axis/AxisBottom';

more info:

@hshoff hshoff added this to the v0.0.151 milestone Jan 12, 2018
@hshoff hshoff modified the milestones: v0.0.151, v0.0.153 Jan 12, 2018
@hshoff hshoff merged commit 6c851d2 into master Jan 12, 2018
@hshoff hshoff deleted the harry-sideeffects branch January 12, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant