softgpu: Avoid fast path in another wrong case #16101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seen in Kurohyo. Missed that the alpha blend check essentially means only standard blending can work.
They were duplicated, and better to organize them according to state.
Since it only supports multiply and add, let's just stick with that.
Seen in Wild Arms XF shop menu.
|
Ah, so much to check... And nice optimization! |
|
Changing display resolution in Darkstalker. Record_2022-09-27-13-15-56.mp4 |
Open
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I double checked more of the state this time, hopefully there's not more. Easier to look at commit-by-commit because I moved some functions around to where they belong.
This was from checking Kurohyo. The bloom effect it does when you encounter an enemy, etc. was the wrong color, because we were going through the fast 5551 path for a fixed ONE + ONE blend, and it was picking only the source color.
I checked this against a Darkstalkers / Vampire Chronicle frame, and it should still be fast (it might even be faster.)
Separately, the triangle strip code was not ending properly when there were triangles or non-flat rectangles at the end of a strip. Wild Arms XF has a good case for this.
-[Unknown]