Detect framebuffers that live in the "stride gap" of others, fix size #15900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -271,7 +304,7 @@ VirtualFramebuffer *FramebufferManagerCommon::DoSetRenderFrameBuffer(const Frame | |||
| // As there are no clear "framebuffer width" and "framebuffer height" registers, | |||
| // we need to infer the size of the current framebuffer somehow. | |||
| int drawing_width, drawing_height; | |||
| EstimateDrawingSize(params.fb_address, params.fb_format, params.viewportWidth, params.viewportHeight, params.regionWidth, params.regionHeight, params.scissorWidth, params.scissorHeight, std::max(params.fb_stride, (u16)4), drawing_width, drawing_height); | |||
| EstimateDrawingSize(params.fb_address, std::max(params.fb_stride, (u16)16), params.fb_format, params.viewportWidth, params.viewportHeight, params.regionWidth, params.regionHeight, params.scissorWidth, params.scissorHeight, drawing_width, drawing_height); | |||
There was a problem hiding this comment.
Hm, it can be specified as 4 iirc, I'm not sure it's true that the floor is 16. It might have a minimum of 16 bytes.
-[Unknown]
There was a problem hiding this comment.
4 just looked suspiciously small. I'll restore it though, not like it'll matter very often anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games, including the ones mentioned in #15898, place a small buffer in the vertical gap, created between a 480px wide main framebuffer, and a stride of 512 pixels. For some reason 512 is regarded as a better stride than 480, so many games size their buffers that way, leaving the gap.
This detects such buffers in a pretty safe and strict way, and make sure that their drawing_width is set accordingly, leading to less memory use and a slightly more sane debugging experience.
This does not solve #15898, but is a small, separate step on the way so let's get it in for testing.