Vulkan:Add more Dirty flag #13762
Closed
Vulkan:Add more Dirty flag #13762
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I'm somewhat surprised that line 594 is not enough ... I'll see what I can figure out... |
|
In line 594,Remove DIRTY_TEXTURE_IMAGE | DIRTY_TEXTURE_PARAMS flag,the game still work |
|
Re-test,just need DIRTY_TEXTURE_IMAGE or DIRTY_TEXTURE_PARAMS is okay |
|
I feel like this implies something else is not properly dirtying texture params... -[Unknown] |
|
@unknownbrackets ,@hrydgard said that my frame dump is okay |
unknownbrackets
added a commit
to unknownbrackets/ppsspp
that referenced
this pull request
Feb 14, 2021
This logs the impacts of hrydgard#13762 so we can see why that helps, even though it doesn't look like a correct fix.
unknownbrackets
added a commit
to unknownbrackets/ppsspp
that referenced
this pull request
Feb 28, 2021
This logs the impacts of hrydgard#13762 so we can see why that helps, even though it doesn't look like a correct fix.
|
Fix in #14233 instead |
unknownbrackets
added a commit
to unknownbrackets/ppsspp
that referenced
this pull request
Oct 13, 2021
This logs the impacts of hrydgard#13762 so we can see why that helps, even though it doesn't look like a correct fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13741
Fix Princess Maker 5 Portable half screen in Vulkan
edit2: Not sure line 839 also need more dirty flag.