Vk validation fixes, plus PowerVR swapchain hack #11747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't close invalid handles.
…n non-harmful perf warning (doesn't fix all cases, but does fix the most common one).
unknownbrackets
approved these changes
Jan 25, 2019
|
I'll fix up SDL. Android rotation works just fine. |
|
Maybe it will even fix the Linux/SDL resizing issue somehow... -[Unknown] |
|
It doesn't. I have a separate branch with an attempt for that which I'll revive soon... |
| return false; | ||
| } | ||
| // Destructor will take care of the image. | ||
| return false; |
There was a problem hiding this comment.
Wait, shouldn't this be inside the ALLOCATE_FAILED if?
-[Unknown]
There was a problem hiding this comment.
Oops what happened here.. sloppy editing. I'll fix soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes us at least boot to a workable menu on PowerVR so you can switch out of Vulkan into OpenGL. However the emulator is still mostly broken, which I attribute to driver bugs at this point. It's also very slow, both in OpenGL and what works of Vulkan, but maybe Honor 7S is just a bad device (#11743).
It's possible that this could help #11457 too.