Ignore broken pipe / SIGPIPE signal to avoid crash #11475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I enabled the remote debugger setting, the emulator crashed immediately. Even without running any game. Also, it started to crash on the start-up, without showing the UI yet. In all cases the crash was because a broken pipe (SIGPIPE).
I am running Linux (Fedora 28) and the issue affects to both QT and SDL versions. Tested with the latest commit of master branch.
Thanks @unknownbrackets for suggesting the fix!
The issue is fixed by ignoring the SIGPIPE signal in the
send
call. The error is still returned asEPIPE
so it can be handled without crashing the whole application.Stacktrace: