Wrap text in many places where it makes sense #8900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This still allows skipping a Measure() override, so that it can still clamp properly.
No reason to wait, just need to keep the buttons hidden. Intentionally hiding even the buttons below the possibly added buttons, so we don't accidentally play "button keep away" with the user.
If something has a flexible width, that may affect its final calculated height. This allows it to grow in such a situation.
Sometimes the savedata info is long, better to wrap than overflow the box.
If the text is too long, they will scroll down first, then wrap.
unknownbrackets
force-pushed
the
ui-text-wrap
branch
from
2bcce0d
to
192d6ca
Compare
|
That's really nice, thanks for digging into the layout system, I've almost forgotten how it works already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps game titles in the game info screen, savedata info in the pop up, a few paths, etc.
The layout system is changed just slightly to more often specify values for UNSPECIFIED sizes, and more importantly, use that value for FILL_PARENT sizes. This exposed a lot of places where FILL_PARENT was incorrectly being used as WRAP_CONTENT, especially tab holders.
This also fixes #8020 with more of a fix and less of a workaround. It was very related - and sometimes when there's network latency, it's nice for the screen to be async as it was originally.
The first two commits are shared with #8898 as they are used by both.
Notably, this does not ever wrap checkboxes / choices as mentioned in #8136. But it makes it significantly more doable.Went ahead and added this.-[Unknown]