-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better support zh_gb.pgf #8884
Better support zh_gb.pgf #8884
Conversation
tag @lightfirst |
@@ -645,9 +645,26 @@ static void __LoadInternalFonts() { | |||
if (!pspFileSystem.GetFileInfo(fontPath).exists) { | |||
pspFileSystem.MkDir(fontPath); | |||
} | |||
if (pspFileSystem.GetFileInfo("disc0:/PSP_GAME/USRDIR/zh_gb.pgf").exists) { | |||
for (size_t i = 0; i < ARRAY_SIZE(fontRegistry); i++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this adds the first font only, and then bails out... I'm pretty sure that's not the way the PSP works. Maybe instead there's a problem in the font matching function?
-[Unknown]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is orignal log:
https://gist.github.com/sum2012/8357a3503e4374e862221e097c72fd36
It seem that the chinese team patched the font.prx (or use scereg ?) to force to use it's custom font.
JPCSP also have this problem although it has scereg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'm not sure it makes sense to affect ALL games that have a zh_gb.pgf for this one game with a patched font.prx. Perhaps we could detect the patch somehow?
-[Unknown]
@unknownbrackets Add more check (oldfont.prx) should be safe enough |
Okay, I guess that seems okay. -[Unknown] |
Before
After
I don't know that ppsspp doesn't choose best font of "disc0:/PSP_GAME/USRDIR/zh_gb.pgf" of this game,so that I need force to use that font when exist.