Return error when trying to close files with pending operations #8868
Conversation
hrydgard
changed the title
|
That vulkan commit I moved to master. Don't know why it still shows here as a diff.. |
| @@ -66,7 +66,8 @@ static const int ERROR_ERRNO_FILE_ALREADY_EXISTS = 0x80010011; | |||
| static const int ERROR_MEMSTICK_DEVCTL_BAD_PARAMS = 0x80220081; | |||
| static const int ERROR_MEMSTICK_DEVCTL_TOO_MANY_CALLBACKS = 0x80220082; | |||
| static const int ERROR_KERNEL_BAD_FILE_DESCRIPTOR = 0x80020323; | |||
|
|
|||
| static const int ERROR_KERNEL_ILLEGAL_PERMISSION = 0x800200d1; | |||
There was a problem hiding this comment.
Should we use SCE_KERNEL_ERROR_ILLEGAL_PERM instead? Same value, and used other places.
-[Unknown]
There was a problem hiding this comment.
I suppose so. I searched the code base for ILLEGAL_PERMISSION, didn't anticipate just "PERM"..
There was a problem hiding this comment.
Yeah.... most of those names came from the "snapshot" commit, not sure.
-[Unknown]
|
This does fix it in the trial, yes. It doesn't fix the animation "tweening" by mip bias, though. -[Unknown] |
|
Well, yeah, it's obviously not expected to fix the mipmap trickery, that should really be a separate issue. |
|
Yeah, of course, was just noting it for people who don't read the code... -[Unknown] |
|
Should add back ERROR_KERNEL_BAD_FILE_DESCRIPTOR error code |
|
@sum2012 we already return SCE_KERNEL_ERROR_BADF in that case, see https://github.com/hrydgard/ppsspp/blob/master/Core/HLE/sceIo.cpp#L1902 |
Also, fix error for trying to close stdin/stderr/stdout.
Blindly tries to help #6357 by trying to do the same thing as jpcsp/jpcsp@61ecddc .
Does it work?